Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privilege: use internal session to run SET DEFAULT ROL ALL (#15525) #15631

Merged
merged 2 commits into from
Mar 25, 2020
Merged

privilege: use internal session to run SET DEFAULT ROL ALL (#15525) #15631

merged 2 commits into from
Mar 25, 2020

Conversation

imtbkcat
Copy link

What problem does this PR solve?

cherry-pick #15525 to release-4.0

@imtbkcat imtbkcat requested a review from a team as a code owner March 24, 2020 08:19
@ghost ghost requested review from qw4990 and wshwsh12 March 24, 2020 08:19
@github-actions github-actions bot added the sig/execution SIG execution label Mar 24, 2020
jackysp
jackysp reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Mar 25, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit cebc5f7 into pingcap:release-4.0 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/privilege sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @sre-bot @jackysp @zz-jason